Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated hass.components usage #3528

Merged
merged 9 commits into from
May 7, 2024
Merged

Replace deprecated hass.components usage #3528

merged 9 commits into from
May 7, 2024

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Feb 28, 2024

@ludeeus ludeeus linked an issue Mar 1, 2024 that may be closed by this pull request
Detected that custom integration 'hacs' accesses hass.components.frontend. This is deprecated and will stop working in Home Assistant 2024.9 #3534
Closed
7 tasks
balloob
balloob approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 🐬 Thanks.

@klimentiy23
Copy link

Регистратор: homeassistant.helpers.frame
Источник: helpers/frame.py:156
Первое сообщение: 05:00:31 (1 сообщений)
Последнее сообщение: 05:00:31

Detected that custom integration 'hacs' accesses hass.components.frontend. This is deprecated and will stop working in Home Assistant 2024.9, it should be updated to import functions used from frontend directly at custom_components/hacs/frontend.py, line 68: hass.components.frontend.async_register_built_in_panel(, please create a bug report at https://github.com/hacs/integration/issues

@mathgim
Copy link

mathgim commented Mar 10, 2024

Having the same issue on 2024.3.0 :-)

@JkJ076
Copy link

JkJ076 commented Mar 13, 2024

Updated HAOS to 2024.3.0, same issue

@UK-JustinSmall
Copy link

Getting this error too but when I check the file line 68 already shows this as

    hass.components.frontend.async_register_built_in_panel(

@ludeeus
Copy link
Member Author

ludeeus commented Mar 14, 2024 •
edited
Loading

This is not an issue, this is a pull request aimed to solved the linked issue, please stop commenting here.

@budswarez
Copy link

budswarez commented Mar 18, 2024 •
edited
Loading

Same problem, see diagnostic log

config_entry-hacs-1907868ab5d448e7265798f4fa0b797c.json

leikoilja
leikoilja approved these changes Mar 18, 2024
View reviewed changes
Copy link

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MartinHjelmare
MartinHjelmare suggested changes Apr 8, 2024
View reviewed changes
custom_components/hacs/base.py Outdated Show resolved Hide resolved
emontnemery
emontnemery approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emontnemery emontnemery mentioned this pull request Apr 11, 2024
Merged
@JCGuima

This comment was marked as off-topic.

Sign in to view
@hacs hacs locked and limited conversation to collaborators Apr 13, 2024
@ludeeus ludeeus merged commit 70aa89c into main May 7, 2024
28 checks passed
@ludeeus ludeeus deleted the hass.components branch May 7, 2024 12:52
@hacs-bot hacs-bot bot added this to the next milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

@leikoilja leikoilja leikoilja approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
pr: bugfix
Projects
None yet
Milestone
2.0.0